expand docs on testing locally #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rapids-ai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ajschmidt8
approved these changes
Aug 8, 2025
Member
Author
|
Thanks for reviewing! Hope this will be helpful for folks. |
This was referenced Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I relied on some miminal local testing + the PR docs preview to test the changes in #654
Those changes did not interact well with the 25.08 release, and had to be reverted: #658
On #657, I'm touching the same code paths (the downloads from S3 and post-processing) and this time found myself wanting much more thorough testing.
I've found a pattern that's working well for me. This proposes adding it to
CONTRIBUTING.md, so others can repeat that testing in the future.Notes for Reviewers
How I tested this
Locally, on my arm64 (M2) Mac.