Skip to content

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Aug 8, 2025

Contributes to rapidsai/build-planning#197 and https://github.com/rapidsai/ops/issues/4044

In #657 (and previously in #654), I'm working on adding an "Inactive Projects" section to https://docs.rapids.ai/api/, and currently struggling to make that work with the post-processing that populates drop-downs like this:

image

ref: https://docs.rapids.ai/api/cudf/stable/user_guide/

To try to make this more manageable to both change and review, this PR proposes some refactoring:

  • copying the contents of ci/customization/util.py into the only place they're used (to eliminate the indirection of an import)
  • switching most functions from relying on global state to instead passing configuration through keyword arguments

This should ONLY be a moving-code-around PR, it isn't intended to change anything about how the docs look or work.

Notes for Reviewers

I'm sorry, I know this has not been the most fun series of PRs to review. Thanks for your patience.

How I tested this

Using the steps added to the docs in #659

./ci/customization/customize_docs_in_folder.sh "_site/api/cudf"

Beyond that, we'll have to merge this to find out if it worked.

@jameslamb jameslamb requested a review from a team as a code owner August 8, 2025 20:25
@netlify
Copy link

netlify bot commented Aug 8, 2025

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ef845a
🔍 Latest deploy log https://app.netlify.com/projects/docs-rapids-ai/deploys/68965d57341c440007a11036
😎 Deploy Preview https://deploy-preview-661--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you deserve a 🍪 for wrangling this mess.

@jameslamb
Copy link
Member Author

Ha no prob, thanks for reviewing! I'll merge this so we can get some feedback from a deployment.

@jameslamb jameslamb merged commit 0786221 into rapidsai:main Aug 8, 2025
6 checks passed
@jameslamb jameslamb deleted the ci/local-state branch August 8, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants