Skip to content

Conversation

@jameslamb
Copy link
Member

Follow-up from #669 (comment)

Re-writes get-projects-to-versions.sh into Python.

Notes for Reviewers

Benefits of this

  • allows it to be run by pre-commit.ci
  • makes maintenance a bit easier (more of us working on this repo are comfortable in Python than are comfortable with bash + jq + yq)

How I tested this

Confirmed that the differences in projects-to-versions.json here are only cosmetic (different sort-ordering), like this:

# on this branch
pre-commit run --all-files
cp ./ci/customization/projects-to-versions.json ./this-pr.json

# 'main' prior to this PR
git checkout '2406041'

# are they the same?
python -c "import json; assert json.load(open('this-pr.json')) == json.load(open('ci/customization/projects-to-versions.json'))"

And confirmed that there are no remaining uses of the shell script version:

git checkout ci/use-python
git grep -E 'get\-project'

@jameslamb jameslamb requested a review from AyodeAwe August 13, 2025 21:34
@jameslamb jameslamb requested a review from a team as a code owner August 13, 2025 21:34
@netlify
Copy link

netlify bot commented Aug 13, 2025

Deploy Preview for docs-rapids-ai ready!

Name Link
🔨 Latest commit afc82d5
🔍 Latest deploy log https://app.netlify.com/projects/docs-rapids-ai/deploys/689df880cc3a4e0007c89b04
😎 Deploy Preview https://deploy-preview-670--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jameslamb jameslamb merged commit ea52d93 into main Aug 14, 2025
6 checks passed
@jameslamb jameslamb deleted the ci/use-python branch August 14, 2025 18:29
@jameslamb jameslamb mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants