-
Notifications
You must be signed in to change notification settings - Fork 65
Index UCXX docs #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index UCXX docs #679
Conversation
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
jameslamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple suggestions.
Once those are applied, I'll approved this but wait to merge it until rapidsai/ucxx#510 is merged and its branch build has completed. That build over in ucxx needs to run first so docs will be available on S3.
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>
jameslamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for working through this. First time we've added a new project since all the changes I made to the process in #670 and related earlier PRs.
I'll merge this once that ucxx PR is merged.
Add UCXX (Python) docs, depends on rapidsai/ucxx#510.