-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gh actions #164
Add gh actions #164
Conversation
…into add-GH-actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @AjayThorve
One question @AjayThorve, do we need to correct a path for CodeCov?
|
I picked the coverage commands from cudf's way of running the python tests, and the path seems similar to what we have in cudf's test coverage. May be @ajschmidt8 can give some pointers. |
Good catch. @madsbk. I didn't notice this. Upon further inspection, it looks like we're seeing some of these source file path discrepancies in @bdice has opened up this PR rapidsai/cudf#12751 to investigate the issue. As long as there are no objections, I think we should merge the PR as-is and fix this in a future iteration. @madsbk, does that work for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor change request
Sounds good to me |
/merge |
These changes should've been included in rapidsai#164. They update the `ops-bot.yaml` file to enable the [Recently Updated Check](https://docs.rapids.ai/resources/recently-updated/) for `kvikio`. Additionally, this PR removes the `external_contributors` key, since it is no longer in use.
These changes should've been included in #164. They update the `ops-bot.yaml` file to enable the [Recently Updated Check](https://docs.rapids.ai/resources/recently-updated/) for `kvikio`. Additionally, this PR removes the `external_contributors` key, since it is no longer in use. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #173
With rapidsai#164 merged, Jenkins/`gpuCI` is no longer in use for `kvikio` and therefore any relevant scripts can be removed.
With #164 merged, Jenkins/`gpuCI` is no longer in use for `kvikio` and therefore any relevant scripts can be removed. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #174
* Add back all build jobs * Add test workflow with new jobs * Temporarily disable push trigger
This PR aims to add GH actions workflow builds and tests to kvikio. To accomplish that, following things have been added:
rapids-dependency-file-generator
cc @ajschmidt8