Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gh actions #164

Merged
merged 62 commits into from
Feb 10, 2023
Merged

Add gh actions #164

merged 62 commits into from
Feb 10, 2023

Conversation

AjayThorve
Copy link
Member

@AjayThorve AjayThorve commented Jan 31, 2023 •
edited
Loading

This PR aims to add GH actions workflow builds and tests to kvikio. To accomplish that, following things have been added:

  • Add dependencies.yaml file and auto-generated environment file via rapids-dependency-file-generator
  • fix a couple of styling issues in pythons scripts to build docs without any warnings
  • add a common ./build.sh script in the root folder to build libkvikio or kvikio, as per the input parameter, mimicing other rapidsai projects build process
  • add workflow files to ./github/workflows
  • add ci scripts to build and test kvikio, libkvikio, and generate docs.
  • ci scripts to test cpp and python builds downloaded from s3.

cc @ajschmidt8

@AjayThorve AjayThorve changed the base branch from branch-23.02 to branch-23.04 January 31, 2023 22:36
@ajschmidt8 ajschmidt8 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 1, 2023
bdice
bdice reviewed Feb 3, 2023
View reviewed changes
ci/check_style.sh Outdated Show resolved Hide resolved
ci/release/update-version.sh Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
bdice
bdice reviewed Feb 8, 2023
View reviewed changes
build.sh Outdated Show resolved Hide resolved
ci/test_python.sh Show resolved Hide resolved
conda/recipes/kvikio/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/kvikio/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libkvikio/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libkvikio/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libkvikio/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libkvikio/meta.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
madsbk
madsbk approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @AjayThorve

@madsbk
Copy link
Member

madsbk commented Feb 9, 2023

One question @AjayThorve, do we need to correct a path for CodeCov?
We get the following output:

 ----- generated xml file: /__w/kvikio/kvikio/test-results/junit-kvikio.xml -----

---------- coverage: platform linux, python 3.8.16-final-0 -----------
Name                                                                       Stmts   Miss  Cover
----------------------------------------------------------------------------------------------
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/__init__.py            9      0   100%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/_lib/__init__.py       0      0   100%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/_version.py            4      0   100%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/cufile.py             39      6    85%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/defaults.py           36     20    44%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/numpy.py              42     42     0%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/nvcomp.py             90     90     0%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/thread_pool.py         5      5     0%
/opt/conda/envs/test/lib/python3.8/site-packages/kvikio/zarr.py               26      1    96%
kvikio/__init__.py                                                             9      9     0%
kvikio/_lib/__init__.py                                                        0      0   100%
kvikio/_version.py                                                           354    354     0%
kvikio/cufile.py                                                              39     39     0%
kvikio/defaults.py                                                            36     36     0%
kvikio/numpy.py                                                               42     42     0%
kvikio/nvcomp.py                                                              90     90     0%
kvikio/thread_pool.py                                                          5      5     0%
kvikio/zarr.py                                                                26     26     0%
----------------------------------------------------------------------------------------------
TOTAL                                                                        852    765    10%
Coverage XML written to file /__w/kvikio/kvikio/coverage-results/kvikio-coverage.xml

@AjayThorve
Copy link
Member Author

One question @AjayThorve, do we need to correct a path for CodeCov? We get the following output:

 ----- generated xml file: /__w/kvikio/kvikio/test-results/junit-kvikio.xml -----

---------- coverage: platform linux, python 3.8.16-final-0 -----------
TOTAL                                                                        852    765    10%
Coverage XML written to file /__w/kvikio/kvikio/coverage-results/kvikio-coverage.xml

I picked the coverage commands from cudf's way of running the python tests, and the path seems similar to what we have in cudf's test coverage. May be @ajschmidt8 can give some pointers.

@ajschmidt8
Copy link
Member

One question @AjayThorve, do we need to correct a path for CodeCov? We get the following output:

Good catch. @madsbk. I didn't notice this.

Upon further inspection, it looks like we're seeing some of these source file path discrepancies in cudf as well (e.g. 1,2).

@bdice has opened up this PR rapidsai/cudf#12751 to investigate the issue.

As long as there are no objections, I think we should merge the PR as-is and fix this in a future iteration.

@madsbk, does that work for you?

ajschmidt8
ajschmidt8 requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change request

dependencies.yaml Outdated Show resolved Hide resolved
@madsbk
Copy link
Member

madsbk commented Feb 10, 2023

As long as there are no objections, I think we should merge the PR as-is and fix this in a future iteration.

@madsbk, does that work for you?

Sounds good to me

@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 715bdb2 into rapidsai:branch-23.04 Feb 10, 2023
@AjayThorve AjayThorve deleted the add-GH-actions branch February 10, 2023 19:25
ajschmidt8 added a commit to ajschmidt8/kvikio that referenced this pull request Feb 11, 2023
@ajschmidt8
Update ops-bot.yaml config
43621ef 
These changes should've been included in rapidsai#164.

They update the `ops-bot.yaml` file to enable the [Recently Updated Check](https://docs.rapids.ai/resources/recently-updated/) for `kvikio`.

Additionally, this PR removes the `external_contributors` key, since it is no longer in use.
@ajschmidt8 ajschmidt8 mentioned this pull request Feb 11, 2023
Merged
rapids-bot bot pushed a commit that referenced this pull request Feb 11, 2023
@ajschmidt8
Update ops-bot.yaml config (#173)
d440ece 
These changes should've been included in #164.

They update the `ops-bot.yaml` file to enable the [Recently Updated Check](https://docs.rapids.ai/resources/recently-updated/) for `kvikio`.

Additionally, this PR removes the `external_contributors` key, since it is no longer in use.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #173
ajschmidt8 added a commit to ajschmidt8/kvikio that referenced this pull request Feb 12, 2023
@ajschmidt8
Remove Jenkins/gpuCI references
6c43257 
With rapidsai#164 merged, Jenkins/`gpuCI` is no longer in use for `kvikio` and therefore any relevant scripts can be removed.
@ajschmidt8 ajschmidt8 mentioned this pull request Feb 12, 2023
Merged
rapids-bot bot pushed a commit that referenced this pull request Feb 13, 2023
@ajschmidt8
Remove Jenkins/gpuCI references (#174)
c152f63 
With #164 merged, Jenkins/`gpuCI` is no longer in use for `kvikio` and therefore any relevant scripts can be removed.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #174
@jakirkham jakirkham mentioned this pull request Aug 1, 2023
Merged
vuule pushed a commit to vuule/kvikio that referenced this pull request Nov 8, 2023
@vyasr
Reenable build and test CI jobs (rapidsai#164)
b0371d9 
* Add back all build jobs

* Add test workflow with new jobs

* Temporarily disable push trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

@bdice bdice bdice approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AjayThorve @ajschmidt8 @madsbk @bdice