Remove sphinx pinning #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
improvement
|
@AjayThorve it looks like this version constraint on Sphinx comes from PR ( #164 ). Do you recall if there was something that motivated that constraint (some bug to workarounds or something)? |
ajschmidt8
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
This is safe to remove.
I forget the specifics, but we pinned this because Sphinx 6 had unintentionally introduced a breaking change that affected pydata-sphinx-theme, but it's been resolved now.
I think it was related to one of the issues below, both of which are now resolved in current versions of pydata-sphinx-theme:
|
Thanks @ajschmidt8 for clarifying. Yep, it was pydata/pydata-sphinx-theme#1094, which was causing the issue. |
AjayThorve
approved these changes
Aug 1, 2023
|
Awesome thanks for confirming everyone. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need for this upper bound pinning, the docs build with the latest Sphinx.