Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CUDA version in one file (and use everywhere else) #101

Merged
merged 14 commits into from
Aug 12, 2024
Merged

Set CUDA version in one file (and use everywhere else) #101

merged 14 commits into from
Aug 12, 2024

Conversation

jakirkham
Copy link
Member

  • Rewrite logic to move CUDA version to one file used everywhere
  • Switch conda-build recipe from sysroot to {{ stdlib('c') }}

jakirkham and others added 14 commits August 12, 2024 15:23
@jakirkham
Wrap yum install over multiple lines
2b8d89b
@jakirkham
Use {{ stdlib('c') }}
abba0fb
@jakirkham
Consolidate CUDA version setting to one place
57ba1e4 
Instead of having the CUDA version hard-coded in a bunch of places,
consolidate it to one file and have everything else load and use that
file.
@jakirkham
Move cuda-version up in host
0f45fed
@jakirkham @bdice
Use cuda-version in requirements/build
856d256 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@jakirkham
Add {{ stdlib('c') }} before cuda-version
b3bf30c
@jakirkham
Pass cuda_version by variants
9b15d34
@jakirkham
Handle pyproject.toml before cuda_version
d0ffcb9
@jakirkham
Drop cuda_version loading in recipe
53de6aa 
This doesn't affect the hash correctly. So drop it.

We should get a different hash when building for a different CUDA
version to help distinguish between packages.
@jakirkham
Switch back to using cuda_compiler_version
8088d44
@jakirkham
Switch back to conda build
216089a 
As both `conda build` and `conda mambabuild` use the same `libmamba`
solver by default, just use `conda build`, which is a bit more flexible
here.
@jakirkham
Format variant as proper JSON
61136a4
@jakirkham
Write cuda_compiler_version to variant file
e4e96ee
@jakirkham
Use YAML for variant file
2a49b4d 
Improve readability a bit.
@jakirkham jakirkham requested review from a team as code owners August 12, 2024 22:24
@jakirkham jakirkham requested a review from msarahan August 12, 2024 22:24
@jakirkham jakirkham merged commit a2f23b7 into rapidsai:main Aug 12, 2024
49 checks passed
@jakirkham jakirkham deleted the simp_cuda_ver branch August 12, 2024 22:52
@jakirkham jakirkham mentioned this pull request Aug 12, 2024
Merged
@jakirkham jakirkham mentioned this pull request Oct 24, 2024
Merged
gmarkall pushed a commit that referenced this pull request Oct 25, 2024
@jakirkham
Release 0.4.0 (#110)
b44e2cb 
* Fix building tests in multi-gpu environment (#98) 
* Change cmake.verbose = true to build.verbose = true (#99) 
* Use build-system.requires to set scikit-build-core minimum version
(#100)
* Set CUDA version in one file (and use everywhere else) (#101) 
* Drop Python 3.9 support (#102) 
* Use CI workflow branch 'branch-24.10' again (#105) 
* Use conda strict channel priority. (#109) 
* Update to CUDA 12.6 (#97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakirkham @bdice