Change cmake.verbose = true to build.verbose = true
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
changed the title
cmake.verbose = truecmake.verbose = true to build.verbose = true
Use now preferred CMake version constraint mechanism. https://scikit-build-core.readthedocs.io/en/latest/configuration.html#cmake-and-ninja-minimum-versions
jameslamb
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Thanks!
Hope it's ok, I pushed a commit adding the other changes for rapidsai/build-planning#58 here as they seemed relevant (setting a floor of scikit-build-core >= 0.10.0, reading the CMake minimum from CMakeLists.txt). Feel free to revert if you disagree, I won't merge this until you've had a chance to respond to that.
|
Restarting CI |
jakirkham
commented
Aug 7, 2024
bdice
approved these changes
Aug 7, 2024
|
Thanks all! 🙏 |
Merged
gmarkall
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Fix building tests in multi-gpu environment (#98) * Change cmake.verbose = true to build.verbose = true (#99) * Use build-system.requires to set scikit-build-core minimum version (#100) * Set CUDA version in one file (and use everywhere else) (#101) * Drop Python 3.9 support (#102) * Use CI workflow branch 'branch-24.10' again (#105) * Use conda strict channel priority. (#109) * Update to CUDA 12.6 (#97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
cmake.verbose = trueis deprecated, drop it from the configReplace it with the now preferred
build.verbose = trueAlso switch from
cmake.minimum-versiontocmake.version, which fixes a CI errorRequire scikit-build-core 0.10.0+