Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Reimplement submdspan. #501

Open
trivialfis opened this issue Feb 9, 2022 · 4 comments
Open

[FEA] Reimplement submdspan. #501

trivialfis opened this issue Feb 9, 2022 · 4 comments
Assignees
@trivialfis
Labels
feature request New feature or request inactive-30d inactive-90d

Comments

@trivialfis
Copy link
Member

Although the mdspan is designed to be flexible, there are limitations on how to integrate customized layouts and accessors. The mdspan in raft is exposed via host_mdspan and device_mdspan so the compiler can prevent us from making some simple mistakes. This customization is achieved by having an additional mixin with the default accessor. Also, in order to implement #497 we need customized layouts. The submdspan reference implementation doesn't support this kind of customization.
@trivialfis trivialfis added the feature request New feature or request label Feb 9, 2022
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@trivialfis trivialfis self-assigned this Apr 26, 2022
@trivialfis
Copy link
Member Author

I will work on this.

@trivialfis trivialfis mentioned this issue Apr 26, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Apr 27, 2022
@trivialfis
Fix mdspan accessor mixin offset policy. (#628)
378354b 
* Derive the offset_policy from the mixin instead of the default accessor.

Partially address #501 .

Authors:
  - Jiaming Yuan (https://github.com/trivialfis)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #628
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@wphicks wphicks mentioned this issue Sep 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trivialfis trivialfis

Labels
feature request New feature or request inactive-30d inactive-90d
Projects
VS/ML/DM Primitives Release Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trivialfis