Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mdspan accessor mixin offset policy. #628

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Fix mdspan accessor mixin offset policy. #628

merged 1 commit into from
Apr 27, 2022

Conversation

trivialfis
Copy link
Member

  • Derive the offset_policy from the mixin instead of the default accessor.

Partially address #501 .

@trivialfis
[FIX] Fix mdspan accessor mixin offset policy.
efed43e 
* Derive the offset_policy from the mixin instead of default accessor.
@trivialfis trivialfis added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Apr 26, 2022
@trivialfis trivialfis requested a review from a team as a code owner April 26, 2022 13:51
@github-actions github-actions bot added the cpp label Apr 26, 2022
@cjnolet
Copy link
Member

cjnolet commented Apr 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 378354b into rapidsai:branch-22.06 Apr 27, 2022
@trivialfis trivialfis deleted the fix-offset-policy branch April 27, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @cjnolet