Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] SLHC should compute distances only across components/colors #743

Closed
cjnolet opened this issue Jul 15, 2022 · 1 comment · Fixed by #1445
Closed

[FEA] SLHC should compute distances only across components/colors #743

cjnolet opened this issue Jul 15, 2022 · 1 comment · Fixed by #1445
Assignees
@tarang-jain
Labels
feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented Jul 15, 2022

Currently SLHC (and HDBSCAN) use MST restarting capability in order to provide additional edges that will connect the original KNN graph. However, since it uses the existing 1-nn primitive which is used for k-means), all of the n^2 distances are computed everytime, which is very wasteful.

These algorithms should see some speedup by computing the distances only across components/colors.
@cjnolet cjnolet added the feature request New feature or request label Jul 15, 2022
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@cjnolet cjnolet assigned tarang-jain and unassigned ahendriksen May 16, 2023
@tarang-jain tarang-jain mentioned this issue May 19, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 25, 2023
@tarang-jain
[FEA] Masked NN for connect_components (#1445)
a66c3a3 
Replace fused L2 Nearest Neighbors in `connect_components` with masked NN.
Closes #743
Closes #1569

Authors:
  - Tarang Jain (https://github.com/tarang-jain)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Allard Hendriksen (https://github.com/ahendriksen)

URL: #1445
@github-project-automation github-project-automation bot moved this from In Progress to Done in VS/ML/DM Primitives Release Board Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarang-jain tarang-jain

Labels
feature request New feature or request
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEA] Masked NN for connect_components tarang-jain/raft
3 participants
@cjnolet @ahendriksen @tarang-jain