[FEA] Masked NN for connect_components #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to update-connected-components
…update-connected-components
…update-connected-components
…update-connected-components
…update-connected-components
…update-connected-components
…update-connected-components
cjnolet
reviewed
May 9, 2023
cpp/include/raft/sparse/neighbors/detail/connect_components.cuh
Outdated
Show resolved
Hide resolved
…update-connected-components
…update-connected-components
…update-connected-components
cjnolet
requested changes
Jul 19, 2023
| @@ -59,21 +59,41 @@ value_idx get_n_components(value_idx* colors, size_t n_rows, cudaStream_t stream | |||
| * @param[in] orig_colors array containing component number for each row of X | |||
| * @param[in] n_rows number of rows in X | |||
| * @param[in] n_cols number of cols in X | |||
| * @param[in] reduction_op | |||
| * @param[in] metric | |||
| * @param[in] reduction_op reduction operation for computing nearest neighbors. The reduction | |||
There was a problem hiding this comment.
Can we also rename this file to cross_component_nn?
cpp/test/matrix/scatter.cu
Outdated
| INSTANTIATE_TEST_CASE_P(ScatterTests, test_name, ::testing::ValuesIn(test_inputs)) | ||
|
|
||
| const std::vector<ScatterInputs<int>> inputs_i32 = | ||
| raft::util::itertools::product<ScatterInputs<int>>({2000}, {6, 31, 129}, {2, 3, 6}, {1234ULL}); |
There was a problem hiding this comment.
Still need more cases here (e.g. different parameter settings).
…update-connected-components
…ng-jain/raft into update-connected-components
cjnolet
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Great work, @tarang-jain! LGTM, but we need to make sure we synchronize the merge with cuml.
ahendriksen
requested changes
Jul 21, 2023
…update-connected-components
…ng-jain/raft into update-connected-components
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jul 26, 2023
Make HDBSCAN MST reduction operation compatible with [#1445](rapidsai/raft#1445) raft PR. This PR updates the Mutual Reachability reduction op in HDBSCAN in the following ways: 1. Colors information is no longer needed in the reduction op because the new `mst` implementation in raft ensures that distances between points of the same color are not computed. 2. Adds gather and scatter functions to rearrange the core distances within the reduction op so that they are aligned with the sort-plan wherein rows in the input matrix and core distances are rearranged so that the training data points are sorted by color. Closes #5456 Authors: - Tarang Jain (https://github.com/tarang-jain) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Divye Gala (https://github.com/divyegala) - Corey J. Nolet (https://github.com/cjnolet) URL: #5386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace fused L2 Nearest Neighbors in
connect_componentswith masked NN.Closes #743
Closes #1569