[REVIEW] Fix race condition in device_scalar::set_value #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
rongou
approved these changes
Sep 21, 2020
harrism
requested changes
Sep 21, 2020
cwharris
suggested changes
Sep 21, 2020
That would break code in cuDF and elsewhere and I didn't want to deal with that in this PR. See #570 |
harrism
approved these changes
Sep 21, 2020
|
rerun tests |
|
@cwharris need approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device_scalar::set_valueperforms a host to device copy to set the value of the contained object. This copy is performed asynchronously and does not perform any synchronization.Previously, the
host_valuewas being passed by value. This is problematic when combined with the fact that the copy was asynchronous. This could mean that the copy would not complete before the function local copy ofhost_valuewas destroyed.I remedied this by making it pass by reference and clarifying the documentation about the asynchronous behavior.