[FEA] Refactor device_scalar in terms of device_uvector and fix asynchrony
#570
Labels
Comments
This was referenced Sep 21, 2020
|
This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. |
|
This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d. |
5 tasks
rapids-bot bot
pushed a commit
that referenced
this issue
Jun 8, 2021
This PR refactors `device_scalar` to use a single-element `device_uvector` for its storage. This simplifies the implementation of device_scalar. Also changes the API of `device_scalar` so that its asynchronous / stream-ordered methods use the same API style (with explicit stream parameter) as `device_uvector` and `device_buffer`. Closes #570 This is a breaking change. When it is merged, PRs are likely to need to be merged immediately in other libraries to account for the API changes. - [x] cuDF: rapidsai/cudf#8411 - [x] cuGraph: rapidsai/cugraph#1637 - [x] RAFT: rapidsai/raft#259 - [x] ~cuML~ (unused) - [x] ~cuSpatial~ (unused) Authors: - Mark Harris (https://github.com/harrism) Approvers: - Rong Ou (https://github.com/rongou) - Jake Hemstad (https://github.com/jrhemstad) URL: #789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
device_scalaris a convenience type to represent a single value in device memory. Anywhere adevice_scalaris used, a single elementdevice_uvectorcould be used.device_scalarwas implemented beforedevice_uvectorexisted, and therefore there is a lot of redundancy between the two.Furthermore, the asynchrony of
device_scalaris incongrous withdevice_uvector. Thedevice_scalar::set_valueis asynchronous, but it's name does not tell you that.We've iterated on this quite a bit, and I feel
device_uvectordemonstrates the ideal design. If a function is asynchronous (doesn't synchronize the stream) it should be suffixed with_async. Otherwise it is synchronous and syncs the stream.Describe the solution you'd like
Refactor
device_scalars implementation to be implemented in terms of a single elementdevice_uvector. Furthermore, reimplement functions likeset_valuein terms ofdevice_uvector::set_element.Likewise,
device_scalar::set_valueshould be made synchronous anddevice_scalar::set_value_asyncshould be added as an asynchronous variant.The text was updated successfully, but these errors were encountered: