Skip to content

Use GitHub Actions artifacts in Anaconda uploads #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameslamb merged 3 commits into from
May 27, 2025
Merged

Use GitHub Actions artifacts in Anaconda uploads #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d5c655
Use GitHub Actions artifacts in Anaconda uploads
jameslamb May 22, 2025
e1ea652
Merge branch 'branch-25.08' into gha-artifacts/uploads
jameslamb May 27, 2025
14552cf
remove AWS auth steps
jameslamb May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/conda-upload-packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,7 @@ jobs:
uses: rapidsai/shared-actions/telemetry-dispatch-setup@main
continue-on-error: true
if: ${{ vars.TELEMETRY_ENABLED == 'true' && github.run_attempt == '1' }}
- uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ vars.AWS_ROLE_ARN }}
aws-region: ${{ vars.AWS_REGION }}
role-duration-seconds: 43200 # 12h
Copy link
Member Author

@jameslamb jameslamb May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized, we probably could remove the step getting AWS creds from these upload workflows as well! Now that they shouldn't need to interact directly with any AWS services.

Wish I'd thought of that before merging rapidsai/cugraph-gnn#215 ... I'll kick off another build there to test that theory.

Copy link
Member Author

@jameslamb jameslamb May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggered a new nightly run of cugraph-gnn like this:

image

Using this commit: rapidsai/cugraph-gnn@915497b

Build link: https://github.com/rapidsai/cugraph-gnn/actions/runs/15281964715/job/42982961992

Copy link
Member Author

@jameslamb jameslamb May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep looked to me like that all worked without AWS creds 😁

https://github.com/rapidsai/cugraph-gnn/actions/runs/15281964715/job/42983516974


- uses: actions/checkout@v4
with:
repository: ${{ inputs.repo }}
Expand Down Expand Up @@ -94,10 +90,11 @@ jobs:
fi
echo "RAPIDS_CONDA_TOKEN=${RAPIDS_CONDA_TOKEN}" >> "${GITHUB_ENV}"
- name: Upload packages
run: rapids-upload-to-anaconda
run: rapids-upload-to-anaconda-github
env:
SKIP_UPLOAD_PKGS: ${{ inputs.skip_upload_pkgs }}
RAPIDS_CONDA_UPLOAD_LABEL: ${{ inputs.upload_to_label }}
GH_TOKEN: ${{ github.token }}
- name: Telemetry upload attributes
uses: rapidsai/shared-actions/telemetry-dispatch-stash-job-artifacts@main
continue-on-error: true
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/wheels-publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,6 @@ jobs:
env:
RAPIDS_BUILD_TYPE: ${{ inputs.build_type }}
steps:
- uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: ${{ vars.AWS_ROLE_ARN }}
aws-region: ${{ vars.AWS_REGION }}
role-duration-seconds: 43200 # 12h

- name: checkout code repo
uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -99,8 +93,9 @@ jobs:
GH_TOKEN: ${{ github.token }}

- name: Download wheels from artifact storage and publish to anaconda repository
run: rapids-wheels-anaconda "${{ inputs.package-name }}" "${{ inputs.package-type }}"
run: rapids-wheels-anaconda-github "${{ inputs.package-name }}" "${{ inputs.package-type }}"
env:
GH_TOKEN: ${{ github.token }}
RAPIDS_CONDA_TOKEN: ${{ secrets.CONDA_RAPIDSAI_WHEELS_NIGHTLY_TOKEN }}

- name: Check if build is release
Expand Down