Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 - Full Page Component Option #1537

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 3, 2023

Original PR: #1430, with thanks to @amshehzad

To Follow: DOCS

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe marked this pull request as draft November 3, 2023 21:59
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1537 (c99f967) into develop (f73b59e) will decrease coverage by 0.01%.
The diff coverage is 90.69%.

@@              Coverage Diff              @@
##             develop    #1537      +/-   ##
=============================================
- Coverage      88.98%   88.98%   -0.01%     
- Complexity      1264     1280      +16     
=============================================
  Files             96       98       +2     
  Lines           2997     3033      +36     
=============================================
+ Hits            2667     2699      +32     
- Misses           330      334       +4     
Files Coverage Δ
...s/Configuration/FullPageComponentConfiguration.php 100.00% <100.00%> (ø)
src/Traits/Helpers/FullPageComponentHelpers.php 100.00% <100.00%> (ø)
src/DataTableComponent.php 88.09% <73.33%> (-8.97%) ⬇️

Copy link

stale bot commented Dec 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 3, 2023
@lrljoe
Copy link
Collaborator Author

lrljoe commented Dec 6, 2023

Replaced by #1580

@lrljoe lrljoe closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant