Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Full Page Component Approach #1580

Merged
merged 24 commits into from
Dec 6, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Dec 6, 2023

The following methods have been added, along with relevant Tests and Docs into the WithCustomisations trait, which will be used going forward for customising the table itself (pending further PRs to consolidate)

  • setLayout for setting layout for component
  • setSlot
  • setExtends
  • setSection

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7ebbe69) 89.08% compared to head (50f13d4) 89.08%.

❗ Current head 50f13d4 differs from pull request most recent head d462653. Consider uploading reports for the commit d462653 to get more accurate results

Files Patch % Lines
src/Traits/WithCustomisations.php 50.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1580      +/-   ##
=============================================
- Coverage      89.08%   89.08%   -0.01%     
- Complexity      1287     1307      +20     
=============================================
  Files             97       99       +2     
  Lines           3042     3078      +36     
=============================================
+ Hits            2710     2742      +32     
- Misses           332      336       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 69a64c3 into rappasoft:develop Dec 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant