Prevent voltage low warnings from filling log #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realised my comment isn't to kernel coding standard. Will fix that. |
JamesH65
force-pushed
the
voltage_ratelimit
branch
from
2f5ccbb
to
2f6099f
Compare
JamesH65
force-pushed
the
voltage_ratelimit
branch
from
2f6099f
to
38c07e3
Compare
Although the correct fix for low voltage warnings is to improve the power supply, the current implementation of the detection can fill the log if the warning happens freqently. This replaces the logging with slightly custom ratelimited logging. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
JamesH65
force-pushed
the
voltage_ratelimit
branch
from
38c07e3
to
67c13bd
Compare
|
Does adding this code / complexity actually accomplish anything useful? I've been following #2512 ... It seems pretty clear that the problem is a hardware issue. It seems backwards to add code / complexity that affects everyone in-order to try and mask one person's issue. It might be debatable if the change fixed a bug, but the original code seems correct and logical... if a power issue is detected, log it... period... no extra complexity necessary. Virtually everyone would agree power issues need to be addressed immediately... the potential of "spamming" the logs is irrelevant. I believe there have been suggestions in #2512 as to how the person could mask any warnings they desire... it could even be suggested that they modify and rebuild with the warning messages completely removed if they like (the great thing about open source code). |
|
@jakemagee This commit ratelimits the logging, which is still present, rather than turning it off completely. Very little extra complexity, I've used the kernel ratelimiting functions so no new code. Although I do agree that the underlying problem should be fixed!! The problems is that some people seem to think ignoring the symptoms is a sensible thing to allow. It isn't, of course, which is why this ratelimits rather than ignoring. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Apr 26, 2018
kernel: BCM270X_DT: Add sdio_overclock parameter kernel: gpiolib: Don't prevent IRQ usage of output GPIOs See: raspberrypi/linux#2527 kernel: Driver for Allo Katana DAC See: raspberrypi/linux#2519 kernel: Prevent voltage low warnings from filling log See: raspberrypi/linux#2520 kernel: overlays: Add 'combine' option to i2c overlays See: #828 firmware: Extra reg writes to ensure the LCD display starts up at 800 wide firmware: platform: Lower temperature thresholds for extra pips to 50/60 firmware: video_encode: Add support for YVU420Planar and YVU420SemiPlanar firmware: video_decode: Support YV12, NV12, and NV21 output firmware: video_decode: Support reporting colour space firmware: IL rawcam: Fix copy/paste error on timing setup firmware: MMAL: Populate buffer header TYPE_SPECIFIC fields
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Apr 26, 2018
kernel: BCM270X_DT: Add sdio_overclock parameter kernel: gpiolib: Don't prevent IRQ usage of output GPIOs See: raspberrypi/linux#2527 kernel: Driver for Allo Katana DAC See: raspberrypi/linux#2519 kernel: Prevent voltage low warnings from filling log See: raspberrypi/linux#2520 kernel: overlays: Add 'combine' option to i2c overlays See: raspberrypi/firmware#828 firmware: Extra reg writes to ensure the LCD display starts up at 800 wide firmware: platform: Lower temperature thresholds for extra pips to 50/60 firmware: video_encode: Add support for YVU420Planar and YVU420SemiPlanar firmware: video_decode: Support YV12, NV12, and NV21 output firmware: video_decode: Support reporting colour space firmware: IL rawcam: Fix copy/paste error on timing setup firmware: MMAL: Populate buffer header TYPE_SPECIFIC fields
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Apr 26, 2018
kernel: BCM270X_DT: Add sdio_overclock parameter kernel: gpiolib: Don't prevent IRQ usage of output GPIOs See: raspberrypi/linux#2527 kernel: Driver for Allo Katana DAC See: raspberrypi/linux#2519 kernel: Prevent voltage low warnings from filling log See: raspberrypi/linux#2520 kernel: overlays: Add 'combine' option to i2c overlays See: #828 firmware: Extra reg writes to ensure the LCD display starts up at 800 wide firmware: platform: Lower temperature thresholds for extra pips to 50/60 firmware: video_encode: Add support for YVU420Planar and YVU420SemiPlanar firmware: video_decode: Support YV12, NV12, and NV21 output firmware: video_decode: Support reporting colour space firmware: IL rawcam: Fix copy/paste error on timing setup firmware: MMAL: Populate buffer header TYPE_SPECIFIC fields
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Apr 26, 2018
kernel: BCM270X_DT: Add sdio_overclock parameter kernel: gpiolib: Don't prevent IRQ usage of output GPIOs See: raspberrypi/linux#2527 kernel: Driver for Allo Katana DAC See: raspberrypi/linux#2519 kernel: Prevent voltage low warnings from filling log See: raspberrypi/linux#2520 kernel: overlays: Add 'combine' option to i2c overlays See: raspberrypi/firmware#828 firmware: Extra reg writes to ensure the LCD display starts up at 800 wide firmware: platform: Lower temperature thresholds for extra pips to 50/60 firmware: video_encode: Add support for YVU420Planar and YVU420SemiPlanar firmware: video_decode: Support YV12, NV12, and NV21 output firmware: video_decode: Support reporting colour space firmware: IL rawcam: Fix copy/paste error on timing setup firmware: MMAL: Populate buffer header TYPE_SPECIFIC fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the correct fix for low voltage warnings is to
improve the power supply, the current implementation
of the detection can fill the log if the warning
happens freqently. This replaces the logging with
slightly custom ratelimited logging.