Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcsm: rpi-4.19.y - gcc-v8 fixes #2897

Merged
merged 3 commits into from
Mar 19, 2019
Merged

vcsm: rpi-4.19.y - gcc-v8 fixes #2897

merged 3 commits into from
Mar 19, 2019

Commits on Mar 19, 2019

  1. vcsm: Fix makefile include on out-of-tree builds 

    The vc_sm module tries to include the 'fs' directory from the
$(srctree). $(srctree) is already provided by the build system, and
causes the include path to be duplicated.

With -Werror this fails to compile.

Remove the unnecessary variable.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
    @kbingham
    kbingham committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    af9fd01 View commit details
    Browse the repository at this point in the history

  2. vcsm: Remove set but unused variable 

    The 'success' variable is set by the call to vchi_service_close() but never checked.
Remove it, keeping the call in place.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
    @kbingham
    kbingham committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    da30285 View commit details
    Browse the repository at this point in the history

  3. vcsm: Reduce scope of local functions 

    The functions:

  vc_vchi_sm_send_msg
  vc_sm_ioctl_alloc
  vc_sm_ioctl_alloc_share
  vc_sm_ioctl_import_dmabuf

Are declared without a prototype. They are not used outside of this
module, thus - convert them to static functions.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
    @kbingham
    kbingham committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    f24d331 View commit details
    Browse the repository at this point in the history