vcsm: rpi-4.19.y - gcc-v8 fixes #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vc_sm module tries to include the 'fs' directory from the $(srctree). $(srctree) is already provided by the build system, and causes the include path to be duplicated. With -Werror this fails to compile. Remove the unnecessary variable. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
The 'success' variable is set by the call to vchi_service_close() but never checked. Remove it, keeping the call in place. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
The functions: vc_vchi_sm_send_msg vc_sm_ioctl_alloc vc_sm_ioctl_alloc_share vc_sm_ioctl_import_dmabuf Are declared without a prototype. They are not used outside of this module, thus - convert them to static functions. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
|
Looks fine to me. |
|
Thanks! |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Mar 20, 2019
kernel: Enable MT76 USB wifi modules See: raspberrypi/linux#2890 kernel: staging: bcm2835-codec: NULL component handle on queue_setup failure See: raspberrypi/linux#2898 kernel: f2fs: fix to skip verifying block address for non-regular inode See: raspberrypi/linux#2896 kernel: vcsm: rpi-4.19.y - gcc-v8 fixes See: raspberrypi/linux#2897 kernel: vc-sm-cma tidy ups, and one for bcm2835_codec See: raspberrypi/linux#2889 kernel: staging: vc_sm_cma: Remove erroneous misc_deregister See: raspberrypi/linux#2888 kernel: video: bcm2708_fb: Try allocating on the ARM and passing to VPU See: raspberrypi/linux#2875 firmware: smservice: Avoid a double free firmware: arm_loader/display: All the framebuffer allocation to be made on the ARM firmware: isp_tuners: Fix memory leak in error path firmware: testc: Fix dps parsing firmware: camera_subsystem: Fix hardware sync pulses off disable_camera_led firmware: Replace the remaining direct users of C(mask_gpu_interrupt[0|1]) firmware: arm_display: Kick transposer for the rainbow screen if required firmware: dispmanx: Do not allow transpose if using Full KMS See: raspberrypi/linux#2891
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Mar 20, 2019
kernel: Enable MT76 USB wifi modules See: raspberrypi/linux#2890 kernel: staging: bcm2835-codec: NULL component handle on queue_setup failure See: raspberrypi/linux#2898 kernel: f2fs: fix to skip verifying block address for non-regular inode See: raspberrypi/linux#2896 kernel: vcsm: rpi-4.19.y - gcc-v8 fixes See: raspberrypi/linux#2897 kernel: vc-sm-cma tidy ups, and one for bcm2835_codec See: raspberrypi/linux#2889 kernel: staging: vc_sm_cma: Remove erroneous misc_deregister See: raspberrypi/linux#2888 kernel: video: bcm2708_fb: Try allocating on the ARM and passing to VPU See: raspberrypi/linux#2875 firmware: smservice: Avoid a double free firmware: arm_loader/display: All the framebuffer allocation to be made on the ARM firmware: isp_tuners: Fix memory leak in error path firmware: testc: Fix dps parsing firmware: camera_subsystem: Fix hardware sync pulses off disable_camera_led firmware: Replace the remaining direct users of C(mask_gpu_interrupt[0|1]) firmware: arm_display: Kick transposer for the rainbow screen if required firmware: dispmanx: Do not allow transpose if using Full KMS See: raspberrypi/linux#2891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked patches from the v5.0.y pull-request that I have also posted.
These fix compilation of the tree with out-of-tree builds (specifying O=) and using a recent GCC (8.2.0-7ubuntu1)