Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staging: bcm2835-codec: NULL component handle on queue_setup failure #2898

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

6by9
Copy link
Contributor

@6by9 6by9 commented Mar 19, 2019

queue_setup tries creating the relevant MMAL component and configures
the input and output ports as we're expecting to start streaming.
If the port configuration failed then it destroyed the component,
but failed to clear the component handle, therefore release tried
destroying the component again.
Adds some logging should the port config fail as well.

Signed-off-by: Dave Stevenson dave.stevenson@raspberrypi.org

queue_setup tries creating the relevant MMAL component and configures
the input and output ports as we're expecting to start streaming.
If the port configuration failed then it destroyed the component,
but failed to clear the component handle, therefore release tried
destroying the component again.
Adds some logging should the port config fail as well.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
@pelwell pelwell merged commit ab92c09 into raspberrypi:rpi-4.19.y Mar 19, 2019
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Mar 20, 2019
kernel: Enable MT76 USB wifi modules
See: raspberrypi/linux#2890

kernel: staging: bcm2835-codec: NULL component handle on queue_setup failure
See: raspberrypi/linux#2898

kernel: f2fs: fix to skip verifying block address for non-regular inode
See: raspberrypi/linux#2896

kernel: vcsm: rpi-4.19.y - gcc-v8 fixes
See: raspberrypi/linux#2897

kernel: vc-sm-cma tidy ups, and one for bcm2835_codec
See: raspberrypi/linux#2889

kernel: staging: vc_sm_cma: Remove erroneous misc_deregister
See: raspberrypi/linux#2888

kernel: video: bcm2708_fb: Try allocating on the ARM and passing to VPU
See: raspberrypi/linux#2875

firmware: smservice: Avoid a double free

firmware: arm_loader/display: All the framebuffer allocation to be made on the ARM

firmware: isp_tuners: Fix memory leak in error path

firmware: testc: Fix dps parsing

firmware: camera_subsystem: Fix hardware sync pulses off disable_camera_led

firmware: Replace the remaining direct users of C(mask_gpu_interrupt[0|1])

firmware: arm_display: Kick transposer for the rainbow screen if required
firmware: dispmanx: Do not allow transpose if using Full KMS
See: raspberrypi/linux#2891
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Mar 20, 2019
kernel: Enable MT76 USB wifi modules
See: raspberrypi/linux#2890

kernel: staging: bcm2835-codec: NULL component handle on queue_setup failure
See: raspberrypi/linux#2898

kernel: f2fs: fix to skip verifying block address for non-regular inode
See: raspberrypi/linux#2896

kernel: vcsm: rpi-4.19.y - gcc-v8 fixes
See: raspberrypi/linux#2897

kernel: vc-sm-cma tidy ups, and one for bcm2835_codec
See: raspberrypi/linux#2889

kernel: staging: vc_sm_cma: Remove erroneous misc_deregister
See: raspberrypi/linux#2888

kernel: video: bcm2708_fb: Try allocating on the ARM and passing to VPU
See: raspberrypi/linux#2875

firmware: smservice: Avoid a double free

firmware: arm_loader/display: All the framebuffer allocation to be made on the ARM

firmware: isp_tuners: Fix memory leak in error path

firmware: testc: Fix dps parsing

firmware: camera_subsystem: Fix hardware sync pulses off disable_camera_led

firmware: Replace the remaining direct users of C(mask_gpu_interrupt[0|1])

firmware: arm_display: Kick transposer for the rainbow screen if required
firmware: dispmanx: Do not allow transpose if using Full KMS
See: raspberrypi/linux#2891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants