dtoverlays: Fix pitft[28|35] overlays for 6.1 driver change. #5508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
|
Do you prefer the split (interrupts, interrupt-parent) notation to the combined irq-gpio style? |
I couldn't get the irq-gpio route to work correctly. The irq-gpio route appears to no longer support edge triggering after conversion from gpio to gpiod calls, but it configures the hardware in a way that seems to leave the STMPE in the IRQ active state, therefore nearly spinning. Switching to the interrupts/interrupt-parent route still allows use of edge triggering, and works as it used. |
|
Fair enough - I've squeezed a link to the Forums thread into the commit message. |
Ta, I regularly forget to add that bit. |
pelwell
pushed a commit
that referenced
this pull request
Jun 21, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
pelwell
pushed a commit
that referenced
this pull request
Jun 21, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Jun 22, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 23, 2023
kernel: driver: media: i2c: imx477: Re-enable temperature sensor See: raspberrypi/linux#5513 kernel: ASoC: cs43130: Fix numerator/denominator mixup See: raspberrypi/linux#5510 kernel: dtoverlays: Fix pitft[28|35] overlays for 6.1 driver change See: raspberrypi/linux#5508 kernel: drivers: media: bcm2835_unicam: Improve frame sequence count handling See: raspberrypi/linux#5507 kernel: overlays: allo-katana-dac-audio: Reduce I2C clock See: raspberrypi/linux#5511
popcornmix
pushed a commit
that referenced
this pull request
Jun 26, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Jun 30, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Jul 3, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Jul 3, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Jul 10, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Jul 10, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Jul 14, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Jul 14, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Jul 20, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Jul 24, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Jul 27, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Aug 3, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Aug 9, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Aug 17, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Sep 5, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Sep 8, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
pushed a commit
that referenced
this pull request
Sep 13, 2023
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device. irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that. See: https://forums.raspberrypi.com/viewtopic.php?t=351394 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overlays configured both irq-gpio and an interrupts/ interrupt-parent configuration for the stmpe MFD device.
irq-gpio was reworked in 6.1 and has issues with the configuration as provided. Removing it and using the interrupts/interrupt-parent configuration works fine, so do that.