ASoC: cs43130: Fix numerator/denominator mixup #5510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In converting to using the standard u16_fract type, commit [1] made the obvious mistake and failed to take account of the difference in numerator and denominator ordering, breaking all uses of the cs43130 codec. Fix it. [1] commit e14bd35 ("ASoC: cs43130: Re-use generic struct u16_fract") Fixes: e14bd35 ("ASoC: cs43130: Re-use generic struct u16_fract") Signed-off-by: Phil Elwell <phil@raspberrypi.com>
|
LGTM |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 23, 2023
kernel: driver: media: i2c: imx477: Re-enable temperature sensor See: raspberrypi/linux#5513 kernel: ASoC: cs43130: Fix numerator/denominator mixup See: raspberrypi/linux#5510 kernel: dtoverlays: Fix pitft[28|35] overlays for 6.1 driver change See: raspberrypi/linux#5508 kernel: drivers: media: bcm2835_unicam: Improve frame sequence count handling See: raspberrypi/linux#5507 kernel: overlays: allo-katana-dac-audio: Reduce I2C clock See: raspberrypi/linux#5511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In converting to using the standard u16_fract type, commit [1] made the obvious mistake and failed to take account of the difference in numerator and denominator ordering, breaking all uses of the cs43130 codec.
Fix it.
[1] commit e14bd35 ("ASoC: cs43130: Re-use generic struct u16_fract")
Fixes: e14bd35 ("ASoC: cs43130: Re-use generic struct u16_fract")