Add example for the PA1010D Mini GPS #151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesH65
reviewed
Sep 2, 2021
|
|
||
| #ifdef i2c_default | ||
| void pa1010d_write_command(char command[], int com_length){ | ||
| // Convert character array to bytes for writing |
There was a problem hiding this comment.
Extra space needed after (
| uint8_t int_command[com_length]; | ||
|
|
||
| for (int i = 0; i < com_length; ++i){ | ||
| int_command[i] = command[i]; |
There was a problem hiding this comment.
Extra space needed after (
There was a problem hiding this comment.
Actually, lots of these in here, so won't flag up the others.
| } | ||
|
|
||
| void pa1010d_read_raw(char numcommand[]) { | ||
| uint8_t buffer[max_read]; |
There was a problem hiding this comment.
would prefer char *numcommand I think.
Closed
Merged
|
Fixed up over in #167. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example for the PA1010D mini GPS. It reads and parses basic location data