Add vLLM TPU example RayService manifest #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
8 tasks
andrewsykim
reviewed
Feb 11, 2025
ray-operator/config/samples/vllm/ray-service.vllm-tpu-v6e-singlehost.yaml
Show resolved
Hide resolved
ray-operator/config/samples/vllm/ray-service.vllm-tpu-v6e-singlehost.yaml
Show resolved
Hide resolved
ray-operator/config/samples/vllm/ray-service.vllm-tpu-v6e-singlehost.yaml
Show resolved
Hide resolved
ray-operator/config/samples/vllm/ray-service.vllm-tpu-v6e-singlehost.yaml
Show resolved
Hide resolved
ray-operator/config/samples/vllm/ray-service.vllm-tpu-v6e-singlehost.yaml
Show resolved
Hide resolved
|
|
||
| def build_app(cli_args: Dict[str, str]) -> serve.Application: | ||
| """Builds the Serve app based on CLI arguments.""" | ||
| ray.init(ignore_reinit_error=True, address="ray://localhost:10001") |
There was a problem hiding this comment.
Is the address="ray://localhost:10001" required?
There was a problem hiding this comment.
I think I needed to add that to get it to work with the RayCluster when submitting it with serve run, otherwise it was consistently starting a local cluster (even though I was port-forwarding to the localhost) and not detecting the remote cluster.
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
andrewsykim
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds an example vLLM RayService TPU manifest for v6e TPUs used in an example guide.
Related issue number
ray-project/ray#47814
Checks