Skip to content

Commit

Permalink
[Serve] Mark long_running_serve_failure test as stable (#32063)
Browse files Browse the repository at this point in the history
The long_running_serve_failure release test is marked as unstable due to recent failures. Recently, #31945 and #32011 have resolved the root causes of these failures. After those changes, the test ran successfully for 15+ hours without failure. This change limits the test's iterations, so it doesn't run forever, and it marks the test as stable.
  • Loading branch information
shrekris-anyscale authored Jan 30, 2023
1 parent fe729aa commit b350f8d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions release/long_running_tests/workloads/serve_failure.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@

# RandomTest setup constants
CPUS_PER_NODE = 10
NUM_ITERATIONS = 350
ACTIONS_PER_ITERATION = 20

RAY_UNIT_TEST = "RAY_UNIT_TEST" in os.environ

Expand Down Expand Up @@ -138,11 +140,10 @@ def verify_deployment(self):
time.sleep(0.01)

def run(self):
iteration = 0
start_time = time.time()
previous_time = start_time
while True:
for _ in range(20):
for iteration in range(NUM_ITERATIONS):
for _ in range(ACTIONS_PER_ITERATION):
actions, weights = zip(*self.weighted_actions)
action_chosen = random.choices(actions, weights=weights)[0]
print(f"Executing {action_chosen}")
Expand All @@ -166,7 +167,6 @@ def run(self):
}
)
previous_time = new_time
iteration += 1

if RAY_UNIT_TEST:
break
Expand Down
2 changes: 1 addition & 1 deletion release/release_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2062,7 +2062,7 @@
group: Long running tests
working_dir: long_running_tests

stable: false
stable: true

legacy:
test_name: serve_failure
Expand Down

0 comments on commit b350f8d

Please sign in to comment.