[Serve] Mark long_running_serve_failure test as stable
#32063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
shrekris-anyscale
requested review from
cadedaniel,
architkulkarni and
sihanwang41
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
cadedaniel
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
LGTM assuming the dashboard change that broke last time is fixed #31741 (comment)
architkulkarni
approved these changes
Jan 30, 2023
architkulkarni
requested changes
Jan 30, 2023
architkulkarni
approved these changes
Jan 30, 2023
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
|
Oh I guess it's a nit, I thought it would halve the number of iterations but it doesn't actually |
Good catch, I removed it. |
sihanwang41
approved these changes
Jan 30, 2023
|
Two tests are failing, but they're unrelated–
This is ready to merge. @sihanwang41 @architkulkarni |
shrekris-anyscale
added
the
tests-ok
clarng
pushed a commit
to clarng/ray
that referenced
this pull request
Jan 31, 2023
…ct#32063) The long_running_serve_failure release test is marked as unstable due to recent failures. Recently, ray-project#31945 and ray-project#32011 have resolved the root causes of these failures. After those changes, the test ran successfully for 15+ hours without failure. This change limits the test's iterations, so it doesn't run forever, and it marks the test as stable.
5 tasks
architkulkarni
pushed a commit
that referenced
this pull request
Feb 6, 2023
…32181) #32063 fixed some issues with the long_running_serve_failure release test and then marked it stable. The test ran successfully afterwards (see test run), but the CI failed to access logs from the cluster and reported the test as errored. The logs were inaccessible on the cluster due to an issue with the cluster setup. Since this test can run without persisting logs, this change drops the logging requirement for this test. Related issue number Closes #32169
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…ct#32063) The long_running_serve_failure release test is marked as unstable due to recent failures. Recently, ray-project#31945 and ray-project#32011 have resolved the root causes of these failures. After those changes, the test ran successfully for 15+ hours without failure. This change limits the test's iterations, so it doesn't run forever, and it marks the test as stable. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…ay-project#32181) ray-project#32063 fixed some issues with the long_running_serve_failure release test and then marked it stable. The test ran successfully afterwards (see test run), but the CI failed to access logs from the cluster and reported the test as errored. The logs were inaccessible on the cluster due to an issue with the cluster setup. Since this test can run without persisting logs, this change drops the logging requirement for this test. Related issue number Closes ray-project#32169 Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shreyas Krishnaswamy shrekris@anyscale.com
Why are these changes needed?
The
long_running_serve_failurerelease test is marked as unstable due to recent failures. Recently, #31945 and #32011 have resolved the root causes of these failures. After those changes, the test ran successfully for 15+ hours without failure. This change limits the test's iterations, so it doesn't run forever, and it marks the test as stable.Related issue number
Closes #31741
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.long_running_serve_failuretest.