Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ray 2.3 release] long_running_serve_failure fails due to misconfigured log file #32169

Closed
cadedaniel opened this issue Feb 1, 2023 · 1 comment · Fixed by #32181
Closed

[Ray 2.3 release] long_running_serve_failure fails due to misconfigured log file #32169

cadedaniel opened this issue Feb 1, 2023 · 1 comment · Fixed by #32181
Assignees
@shrekris-anyscale
Labels
P0 Issues that should be fixed in short order release-blocker P0 Issue that blocks the release serve Ray Serve Related Issue

Comments

@cadedaniel
Copy link
Member

From @shrekris-anyscale:

The test itself ran successfully, but it reported as an error because it logged its updates to the wrong file.
@cadedaniel cadedaniel added release-blocker P0 Issue that blocks the release P0 Issues that should be fixed in short order labels Feb 1, 2023
@shrekris-anyscale shrekris-anyscale mentioned this issue Feb 1, 2023
Merged
5 tasks
@zhe-thoughts zhe-thoughts added the serve Ray Serve Related Issue label Feb 6, 2023
architkulkarni pushed a commit that referenced this issue Feb 6, 2023
@shrekris-anyscale
[Serve] Remove logging requirement for long_running_serve_failure (#…
2314775 
…32181)

#32063 fixed some issues with the long_running_serve_failure release test and then marked it stable. The test ran successfully afterwards (see test run), but the CI failed to access logs from the cluster and reported the test as errored. The logs were inaccessible on the cluster due to an issue with the cluster setup.

Since this test can run without persisting logs, this change drops the logging requirement for this test.

Related issue number
Closes #32169
@cadedaniel
Copy link
Member Author

Re-opening this until the fix is cherry-picked into 2.3.0

@cadedaniel cadedaniel reopened this Feb 6, 2023
@shrekris-anyscale shrekris-anyscale mentioned this issue Feb 6, 2023
Merged
5 tasks
edoakes pushed a commit to edoakes/ray that referenced this issue Mar 22, 2023
@shrekris-anyscale @edoakes
[Serve] Remove logging requirement for long_running_serve_failure (r…
9b5cf0f 
…ay-project#32181)

ray-project#32063 fixed some issues with the long_running_serve_failure release test and then marked it stable. The test ran successfully afterwards (see test run), but the CI failed to access logs from the cluster and reported the test as errored. The logs were inaccessible on the cluster due to an issue with the cluster setup.

Since this test can run without persisting logs, this change drops the logging requirement for this test.

Related issue number
Closes ray-project#32169

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shrekris-anyscale shrekris-anyscale

Labels
P0 Issues that should be fixed in short order release-blocker P0 Issue that blocks the release serve Ray Serve Related Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Serve] Remove logging requirement for long_running_serve_failure shrekris-anyscale/ray
3 participants
@cadedaniel @zhe-thoughts @shrekris-anyscale