Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests]migrate test-many-tasks/test-dead-actors to nightly tests #16469

Merged
merged 3 commits into from
Jun 19, 2021

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Jun 16, 2021

This probably doesn't work as I don't have proper credentials set-up yet. But might worth put it up for early feedbacks.
image

@scv119 scv119 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 16, 2021
min_workers: 100
max_workers: 100
use_spot: true
resources: {"CPU": 2}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPU: 100

@scv119 scv119 force-pushed the migrate-test branch 5 times, most recently from e959d2f to edb0eb8 Compare June 17, 2021 05:42
@scv119 scv119 removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 17, 2021
@scv119 scv119 changed the title [tests][wip]migrate stress-test/test-many-tasks to nightly tests [tests]migrate test-many-tasks/test-dead-actors to nightly tests Jun 17, 2021
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Let me add this to the nightly test. Let's discuss with @krfricke how we can run the weekly test

head_node_type:
name: head_node
instance_type: m4.16xlarge
resources:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we needed sth like resources: 100 before. Why did we remove it?

@krfricke
Copy link
Contributor

This looks good, I'll try to kick these off later today!

Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass!

https://buildkite.com/ray-project/periodic-ci/builds/189#b6374142-7523-4312-ae85-c9e1805dc002

One thing Im wondering is if we should just move this to stress_tests directory? The nightly_tests directory doesn't make much sense and should probably moved anyway.

release/nightly_tests/nightly_tests.yaml Outdated Show resolved Hide resolved
release/nightly_tests/nightly_tests.yaml Outdated Show resolved Hide resolved
@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 18, 2021
scv119 and others added 2 commits June 18, 2021 12:01
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
@scv119 scv119 removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 18, 2021
@rkooo567
Copy link
Contributor

@krfricke We are currently aggregating test suites using the nightly_test keyword. Why don't we merge it and rename the whole test suite as Ray_core_tests or sth?

@rkooo567
Copy link
Contributor

Test failures should be unrelated

@rkooo567 rkooo567 merged commit 853caea into ray-project:master Jun 19, 2021
@rkooo567
Copy link
Contributor

Also, @krfricke can you set this up running weekly?

scv119 pushed a commit that referenced this pull request Jan 3, 2023
The cyphon version usually gets upgraded with new python version, so this shows up in PR like #21244, removing the unnecesary pin as per #21244 (comment)

I believe this was first introduced in this PR #16469.
Signed-off-by: rickyyx <rickyx@anyscale.com>
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
The cyphon version usually gets upgraded with new python version, so this shows up in PR like #21244, removing the unnecesary pin as per #21244 (comment)

I believe this was first introduced in this PR #16469.
Signed-off-by: rickyyx <rickyx@anyscale.com>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
The cyphon version usually gets upgraded with new python version, so this shows up in PR like ray-project#21244, removing the unnecesary pin as per ray-project#21244 (comment)

I believe this was first introduced in this PR ray-project#16469.
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants