-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests]migrate test-many-tasks/test-dead-actors to nightly tests #16469
Conversation
min_workers: 100 | ||
max_workers: 100 | ||
use_spot: true | ||
resources: {"CPU": 2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPU: 100
e959d2f
to
edb0eb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Let me add this to the nightly test. Let's discuss with @krfricke how we can run the weekly test
head_node_type: | ||
name: head_node | ||
instance_type: m4.16xlarge | ||
resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember we needed sth like resources: 100
before. Why did we remove it?
This looks good, I'll try to kick these off later today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass!
https://buildkite.com/ray-project/periodic-ci/builds/189#b6374142-7523-4312-ae85-c9e1805dc002
One thing Im wondering is if we should just move this to stress_tests
directory? The nightly_tests
directory doesn't make much sense and should probably moved anyway.
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
@krfricke We are currently aggregating test suites using the nightly_test keyword. Why don't we merge it and rename the whole test suite as Ray_core_tests or sth? |
Test failures should be unrelated |
Also, @krfricke can you set this up running weekly? |
The cyphon version usually gets upgraded with new python version, so this shows up in PR like ray-project#21244, removing the unnecesary pin as per ray-project#21244 (comment) I believe this was first introduced in this PR ray-project#16469. Signed-off-by: rickyyx <rickyx@anyscale.com> Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
This probably doesn't work as I don't have proper credentials set-up yet. But might worth put it up for early feedbacks.