upgrade cython to 0.29.26 for py310 #21244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmoritz
approved these changes
Dec 23, 2021
|
cc @ericl @edoakes @richardliaw Can one of you have a look/approve/merge it? |
ericl
approved these changes
Dec 27, 2021
| @@ -5,7 +5,7 @@ python: | |||
| pip_packages: | |||
| - terminado | |||
| - boto3 | |||
| - cython==0.29.0 | |||
| - cython==0.29.26 | |||
There was a problem hiding this comment.
+1, let's try to remove it in a follow up PR :)
7 tasks
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
The cyphon version usually gets upgraded with new python version, so this shows up in PR like ray-project#21244, removing the unnecesary pin as per ray-project#21244 (comment) I believe this was first introduced in this PR ray-project#16469. Signed-off-by: rickyyx <rickyx@anyscale.com> Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
cython versions needs to be updated to at least this commit: cython/cython@d8e93b3 to work with py39 and later. The earliest cython version with this commit is 0.29.20. When upgrading mentions of cython version in our codebase, I noticed that we were using multiple cython versions. In lieu of this I decided to make all instances of cython versions consistent at the latest cython relaese of 0.29.26. This versions works all the way back to py36.
Related issue number
Required before #21221 gets merged.
Checks
scripts/format.shto lint the changes in this PR.