[tune] Fix tune_cloud_* tests fow new Trial dict #32010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <kai@anyscale.com>
cadedaniel
approved these changes
Jan 27, 2023
| @@ -77,7 +77,7 @@ def __init__( | |||
| trial_id: str, | |||
| status: str, | |||
| config: Dict[str, Any], | |||
| local_dir: str, | |||
| _local_dir: str, | |||
There was a problem hiding this comment.
I wonder if it's possible to write basic unit tests for the release tests to catch these kind of errors earlier?
There was a problem hiding this comment.
It looks like some AIR/ML release tests have smoke tests, but not all of our release tests have a smoke test version.
justinvyu
approved these changes
Jan 27, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…y-project#32010) ray-project#31669 changed the `Trial.__dict__` by moving `local_dir` to `_local_dir`, which resulted in an error in our tune cloud tests. This PR updates the signature of the `TrialStub` class to resolve the issue. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke kai@anyscale.com
Why are these changes needed?
#31669 changed the
Trial.__dict__by movinglocal_dirto_local_dir, which resulted in an error in our tune cloud tests. This PR updates the signature of theTrialStubclass to resolve the issue.Related issue number
Closes #32007
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.