Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Fix tune_cloud_* tests fow new Trial dict #32010

Merged
merged 1 commit into from
Jan 27, 2023
Merged

[tune] Fix tune_cloud_* tests fow new Trial dict #32010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions release/tune_tests/cloud_tests/workloads/run_cloud_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def __init__(
trial_id: str,
status: str,
config: Dict[str, Any],
local_dir: str,
_local_dir: str,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's possible to write basic unit tests for the release tests to catch these kind of errors earlier?

Copy link
Contributor

@justinvyu justinvyu Jan 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some AIR/ML release tests have smoke tests, but not all of our release tests have a smoke test version.

experiment_tag: str,
_last_result: Dict[str, Any],
relative_logdir: str,
Expand All @@ -88,7 +88,7 @@ def __init__(
self.trial_id = trial_id
self.status = status
self.config = config
self.local_dir = local_dir
self.local_dir = _local_dir
self.experiment_tag = experiment_tag
self.last_result = _last_result
self.relative_logdir = relative_logdir
Expand Down