[Datasets] Fix sort nightly test to skip stats() if exception is raised
#32329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Su <scnju13@gmail.com>
jianoaix
approved these changes
Feb 8, 2023
clarkzinzow
approved these changes
Feb 8, 2023
cadedaniel
approved these changes
Feb 8, 2023
jianoaix
approved these changes
Feb 8, 2023
| @@ -119,6 +119,7 @@ def make_block(count: int, num_columns: int) -> Block: | |||
| else: | |||
| ds = ds.sort(key="c_0") | |||
| ds.fully_executed() | |||
| print(ds.stats()) | |||
There was a problem hiding this comment.
nit: to keep the stats coming after the "finished" etc, assign ds.stats() to a variable and use later for print.
Signed-off-by: Cheng Su <scnju13@gmail.com>
c21
added a commit
to c21/ray
that referenced
this pull request
Feb 9, 2023
7 tasks
cadedaniel
pushed a commit
that referenced
this pull request
Feb 9, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…ised (ray-project#32329) Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cheng Su scnju13@gmail.com
Why are these changes needed?
As title, if
ds.fully_executed()has exception, we should not catch exception and callds.stats(), because at that time,ds.stats()would have undefined behavior. Change to skip calling ofds.stats()by putting all dataset operation in one code block.This is to help debug the real issue of #32203 .
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.