Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3][Datasets] Fix sort nightly test to skip stats() if exception is raised #32366

Merged
merged 1 commit into from
Feb 9, 2023
Merged

[2.3][Datasets] Fix sort nightly test to skip stats() if exception is raised #32366

merged 1 commit into from
Feb 9, 2023

Conversation

c21
Copy link
Contributor

@c21 c21 commented Feb 9, 2023 •
edited
Loading

Why are these changes needed?

Cherry pick of #32329, for release blocker #32203 .

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

cadedaniel
cadedaniel approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@cadedaniel cadedaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @zhe-thoughts

zhe-thoughts
zhe-thoughts approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Let's cherry pick into 2.3.0

@cadedaniel cadedaniel merged commit 2e3bcdb into ray-project:releases/2.3.0 Feb 9, 2023
@c21 c21 deleted the cherry-pick-1 branch February 9, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadedaniel cadedaniel cadedaniel approved these changes

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@jianoaix jianoaix jianoaix approved these changes

Assignees

@cadedaniel cadedaniel

@jianoaix jianoaix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c21 @cadedaniel @zhe-thoughts @jianoaix