Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] setting up grafana and prometheus #32606

Merged
merged 2 commits into from
Feb 16, 2023
Merged

[docs] setting up grafana and prometheus #32606

merged 2 commits into from
Feb 16, 2023

Conversation

alanwguo
Copy link
Contributor

Why are these changes needed?

Cherry-pick of #31129

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

cadedaniel
cadedaniel approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@cadedaniel cadedaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for doctest to pass then ship it

@cadedaniel cadedaniel self-assigned this Feb 16, 2023
@angelinalg
Copy link
Contributor

I just realized that you're trying to ship this. I'll stop my edits now. Feel free to ignore them.

@alanwguo @angelinalg
Apply suggestions from code review
12b5952 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Alan Guo <aguo@aguo.software>
@alanwguo
Copy link
Contributor Author

@angelinalg , np. I applied your edits. I'll also port these edits over to the master branch

@alanwguo alanwguo mentioned this pull request Feb 16, 2023
Merged
7 tasks
@cadedaniel cadedaniel merged commit af4fb35 into ray-project:releases/2.3.0 Feb 16, 2023
architkulkarni pushed a commit that referenced this pull request Mar 10, 2023
@alanwguo @angelinalg
[Doc] Update copy for metrics documentation (#32614)
23bad6b 
These edits were applied to the cherry-pick PR #32606 . I'm porting those edits back to the master branch

Signed-off-by: Alan Guo <aguo@aguo.software>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
@alanwguo @angelinalg @ProjectsByJackHe
[Doc] Update copy for metrics documentation (ray-project#32614)
69ca0c7 
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch

Signed-off-by: Alan Guo <aguo@aguo.software>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@alanwguo @angelinalg @edoakes
[Doc] Update copy for metrics documentation (ray-project#32614)
b86a870 
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch

Signed-off-by: Alan Guo <aguo@aguo.software>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
@alanwguo @angelinalg @peytondmurray
[Doc] Update copy for metrics documentation (ray-project#32614)
c2209b8 
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch

Signed-off-by: Alan Guo <aguo@aguo.software>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@alanwguo @angelinalg @elliottower
[Doc] Update copy for metrics documentation (ray-project#32614)
a2f9c83 
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch

Signed-off-by: Alan Guo <aguo@aguo.software>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@alanwguo @angelinalg @ProjectsByJackHe
[Doc] Update copy for metrics documentation (ray-project#32614)
7c97bad 
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch

Signed-off-by: Alan Guo <aguo@aguo.software>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg left review comments

@cadedaniel cadedaniel cadedaniel approved these changes

@architkulkarni architkulkarni Awaiting requested review from architkulkarni architkulkarni is a code owner

@wuisawesome wuisawesome Awaiting requested review from wuisawesome wuisawesome is a code owner

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman DmitriGekhtman is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

Assignees

@cadedaniel cadedaniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanwguo @angelinalg @cadedaniel