Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for metrics documentation #32614

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

alanwguo
Copy link
Contributor

Why are these changes needed?

These edits were applied to the cherry-pick PR #32606 . I'm porting those edits back to the master branch

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Alan Guo <aguo@aguo.software>
@angelinalg
Copy link
Contributor

LGTM!

@alanwguo
Copy link
Contributor Author

@rkooo567 , can you help merge this?

Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@architkulkarni architkulkarni merged commit 23bad6b into ray-project:master Mar 10, 2023
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch

Signed-off-by: Alan Guo <aguo@aguo.software>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch

Signed-off-by: Alan Guo <aguo@aguo.software>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch

Signed-off-by: Alan Guo <aguo@aguo.software>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch

Signed-off-by: Alan Guo <aguo@aguo.software>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch

Signed-off-by: Alan Guo <aguo@aguo.software>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants