-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copy for metrics documentation #32614
Merged
architkulkarni
merged 1 commit into
ray-project:master
from
alanwguo:update-metrics-docs
Mar 10, 2023
Merged
Update copy for metrics documentation #32614
architkulkarni
merged 1 commit into
ray-project:master
from
alanwguo:update-metrics-docs
Mar 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Alan Guo <aguo@aguo.software>
alanwguo
requested review from
architkulkarni,
wuisawesome,
DmitriGekhtman,
maxpumperla,
pcmoritz and
a team
as code owners
February 16, 2023 03:26
LGTM! |
architkulkarni
approved these changes
Feb 27, 2023
@rkooo567 , can you help merge this? |
angelinalg
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch Signed-off-by: Alan Guo <aguo@aguo.software> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch Signed-off-by: Alan Guo <aguo@aguo.software> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch Signed-off-by: Alan Guo <aguo@aguo.software> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch Signed-off-by: Alan Guo <aguo@aguo.software> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
These edits were applied to the cherry-pick PR ray-project#32606 . I'm porting those edits back to the master branch Signed-off-by: Alan Guo <aguo@aguo.software> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
These edits were applied to the cherry-pick PR #32606 . I'm porting those edits back to the master branch
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.