-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serve] Shutdown http proxy state (cherry-pick) #35446
[serve] Shutdown http proxy state (cherry-pick) #35446
Conversation
Shutdown http proxy state so that it won't run anything in its update loop once a shutdown signal is received. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for picking into 2.5.0
this breaks lint #35454 |
also it's a bad idea to modify cherry picks.. makes it really hard to debug failures on the release branch. we should cherry pick only the commit from master, no modifications! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this breaks lint #35454
remove print statement from the cherry pick.
also it's a bad idea to modify cherry picks.. makes it really hard to debug failures on the release branch. we should cherry pick only the commit from master, no modifications!
Thanks @cadedaniel . Yup I should've looked more carefully myself @zcin Could you please address Cade's comments (especially the CI breakage)? Thanks |
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
CI is fixed, and all commits on this PR are now cherry-picked from master. Serve test failures (I believe both should be fixed by #35426):
Other tests seem unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. test_multiprocessing_client_mode is failing but also on master.
Why are these changes needed?
Cherry pick #35395 and #35439
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.