Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Upgrade docs build system #41115

Merged

Conversation

peytondmurray
Copy link
Contributor

@peytondmurray peytondmurray commented Nov 14, 2023

Why are these changes needed?

This PR upgrades the build system for the docs.

Related issue number

Closes #37944.

Will contain all the changes in #39766, but will be reviewed in pieces via PRs against this branch.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@peytondmurray
Copy link
Contributor Author

peytondmurray commented Nov 16, 2023

Todo

  • Move the parse_navbar_config etc. to e.g. custom_directives.py
  • Resolve conflicts with master

@peytondmurray peytondmurray force-pushed the docs-build-system-upgrade branch from f6532c3 to bc9230d Compare November 16, 2023 20:36
@peytondmurray
Copy link
Contributor Author

peytondmurray commented Nov 16, 2023

According to RTD support the build is timing out (??). This takes 8m locally...troubleshooting now.

@peytondmurray peytondmurray force-pushed the docs-build-system-upgrade branch 3 times, most recently from 441f24c to 25c4160 Compare November 18, 2023 01:53
@peytondmurray
Copy link
Contributor Author

peytondmurray commented Nov 18, 2023

Note: I had to reduce the version of watchfiles to 0.19.0 due to the premerge check. I'd argue the constraints should not be applied to the doc build requirements, as they're separate from the rest of the ray requirements.

Once click-contrib/sphinx-click#129 is merged, we can remove this dependency from the requirements-doc.txt.

@angelinalg
Copy link
Contributor

angelinalg commented Nov 20, 2023

  • The Ask AI button doesn't have a clear border. It should also be black in non-dark-mode. The Ask AI button is black in dark mode, so perhaps the color setting is just reversed.
Screenshot 2023-11-20 at 10 08 39 AM Screenshot 2023-11-20 at 10 23 43 AM
  • The search bar changes size/flashes when you click on the side bar. (This is not a blocker, but we should polish it up if we can in a follow up if it's too big of a lift for this PR.)
Screen.Recording.2023-11-20.at.10.17.00.AM.mov
  • The dark mode switch has three modes. Two of them seem to be the same dark mode. Is this intentional?
  • We lost the Welcome to Ray page in the side bar, that links to the top level landing page. Overview also got a new child page, Learn more. I think Learn more is included in the Getting started page on master. Is there a reason this PR rearranges that?

@emmyscode
Copy link
Member

emmyscode commented Nov 20, 2023

  • Some inconsistencies on the main landing page with padding and a permanent light background for the code samples.
  • How does the user select the Ray version?
  • Footer includes Sphinx version information; do we want this?
  • The AskAI button has a very faint background so it doesn't look like a clickable button; missing Ray logo
  • In the rightmost column on pages, there's an "Edit on Github" button; is that something we want?

@peytondmurray peytondmurray force-pushed the docs-build-system-upgrade branch from 59f8fa0 to 6b07aac Compare November 20, 2023 22:12
ci/ray_ci/doc_builder_container.py Outdated Show resolved Hide resolved
ci/ray_ci/tests.env.Dockerfile Show resolved Hide resolved
@peytondmurray peytondmurray force-pushed the docs-build-system-upgrade branch from f559c6a to e327fa2 Compare November 20, 2023 23:57
@can-anyscale
Copy link
Collaborator

nit: can we add a line here https://github.com/ray-project/ray/blob/master/ci/pipeline/determine_tests_to_run.py#L276 something like:

elif changed_file == ".readthedocs.yaml":
  RAY_CI_DOC_AFFECTED = 1

It will help to get CI results quicker. The entire test suite is run on this change despite this is only a doc change.

@peytondmurray peytondmurray force-pushed the docs-build-system-upgrade branch from e327fa2 to 06bc86f Compare November 21, 2023 00:24
@peytondmurray peytondmurray marked this pull request as ready for review November 21, 2023 03:28
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
@peytondmurray peytondmurray force-pushed the docs-build-system-upgrade branch from 72848dd to f856709 Compare November 27, 2023 21:44
Signed-off-by: pdmurray <peynmurray@gmail.com>
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@can-anyscale can-anyscale merged commit 8919bf0 into ray-project:master Nov 28, 2023
2 checks passed
@peytondmurray peytondmurray deleted the docs-build-system-upgrade branch November 28, 2023 01:15
@JoshTanke
Copy link
Contributor

@peytondmurray Was doc/source/ray-overview/eco-gallery.yml supposed to be deleted? Is there a new place to add integrations now?

@peytondmurray
Copy link
Contributor Author

@JoshTanke Yes, it was. Those integrations were being generated from that yaml file and inserted into ray-overview/ray-libraries.rst. Rather than have the extra step, just modify ray-overview/ray-libraries.rst directly.

@JoshTanke
Copy link
Contributor

@JoshTanke Yes, it was. Those integrations were being generated from that yaml file and inserted into ray-overview/ray-libraries.rst. Rather than have the extra step, just modify ray-overview/ray-libraries.rst directly.

makes sense, thank you for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] [docs infra] Finish Sphinx migration