Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix busted AI assistant CSS #41452

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

peytondmurray
Copy link
Contributor

@peytondmurray peytondmurray commented Nov 28, 2023

Why are these changes needed?

The docs upgrade (#41115) broke light styles for the ray AI assistant. This PR fixes the styles to make the assistant usable again.

There are a few changes which would be nice to make but are more invasive, and therefore out of scope for this PR (such as centering the placeholder text in the textarea element, which really isn't possible unless you use an input or div instead; see https://github.com/ray-project/ray/blob/master/doc/source/ray-overview/examples.rst?plain=1 for an example of how to do this).

Light mode:

image

Dark mode:

image

Related issue number

Closes #41440.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: pdmurray <peynmurray@gmail.com>
@peytondmurray peytondmurray added P0 Issues that should be fixed in short order docs An issue or change related to documentation labels Nov 28, 2023
@peytondmurray peytondmurray requested a review from a team as a code owner November 28, 2023 21:02
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for turning this around so quickly, @peytondmurray.

@pcmoritz pcmoritz merged commit 8ac4cd8 into ray-project:master Nov 29, 2023
9 of 10 checks passed
@peytondmurray peytondmurray deleted the fix-ask-ai-styles branch November 29, 2023 05:59
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
Signed-off-by: pdmurray <peynmurray@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation P0 Issues that should be fixed in short order
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Ask AI app no longer properly rendered as of Ray 3.0.0.dev0 docs release
3 participants