[Core] Better log format when show the disk size #46869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhilong <zhilong.chen@mail.mcgill.ca>
anyscalesam
added
dashboard
Bye-legumes
changed the title
alanwguo
reviewed
Aug 6, 2024
src/ray/common/file_system_monitor.h
Outdated
| private: | ||
| FRIEND_TEST(FileSystemTest, TestOverCapacity); | ||
| const std::vector<std::string> paths_; | ||
| const double capacity_threshold_; | ||
| std::atomic<bool> over_capacity_; | ||
| std::atomic<uint64_t> initial_capacity_{0}; |
There was a problem hiding this comment.
oh. Sorry about that, I just fixed. It's some config that I used to testing. Sorry! Now it fixed now! Thanks!
anyscalesam
added
core
jjyao
removed
the
triage
jjyao
approved these changes
Oct 29, 2024
Co-authored-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: zhilong <121425509+Bye-legumes@users.noreply.github.com>
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
Signed-off-by: zhilong <zhilong.chen@mail.mcgill.ca>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
Signed-off-by: zhilong <zhilong.chen@mail.mcgill.ca>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
Signed-off-by: zhilong <zhilong.chen@mail.mcgill.ca> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
As I mentioned in #46868,
When the disk is near full, ray will have log looks like this
Since the log is difficult to read, I changed it to read as GB instead of bytes. i.e. (this just show the effect as I doesn't include 1 to show the format)
@liuxsh9 @Superskyyy @nemo9cby this will have better log format
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.