Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Better log format when show the disk size #46869

Merged
merged 12 commits into from
Oct 30, 2024
Merged

[Core] Better log format when show the disk size #46869

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
299a0f8
fix_file_detection
Bye-legumes Jul 30, 2024
ae20b53
Merge branch 'master' into fix_file_detection
Bye-legumes Aug 6, 2024
407572e
fix
Bye-legumes Aug 6, 2024
d73dd5a
Merge branch 'master' into fix_file_detection
Bye-legumes Aug 6, 2024
c29f378
fix
Bye-legumes Aug 6, 2024
156610a
fix
Bye-legumes Aug 6, 2024
f243ecb
Merge branch 'master' into fix_file_detection
Bye-legumes Oct 29, 2024
867cae1
Update src/ray/common/file_system_monitor.cc
Bye-legumes Oct 29, 2024
f4227e6
fix
Bye-legumes Oct 29, 2024
97689b2
Merge branch 'master' into fix_file_detection
Bye-legumes Oct 29, 2024
0b78b7c
Merge branch 'master' into fix_file_detection
Bye-legumes Oct 29, 2024
d8b15ef
Merge branch 'master' into fix_file_detection
Bye-legumes Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/ray/common/file_system_monitor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,15 @@ bool FileSystemMonitor::OverCapacityImpl(
return false;
}

// Convert bytes to GB
const double available_gb =
static_cast<double>(space_info->available) / (1024 * 1024 * 1024);
double capacity_gb = static_cast<double>(space_info->capacity) / (1024 * 1024 * 1024);

std::ostringstream ostr;
ostr << path << " is over " << capacity_threshold_ * 100
<< "\% full, available space: " << space_info->available
<< "; capacity: " << space_info->capacity
<< "\% full, available space: " << available_gb << " GB"
<< "; capacity: " << capacity_gb << " GB"
<< ". Object creation will fail if spilling is required.";
RAY_EVENT_EVERY_MS(ERROR, "Out of Disk", 10 * 1000) << ostr.str();
RAY_LOG_EVERY_MS(ERROR, 10 * 1000) << ostr.str();
Expand Down