Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Handle logs from tensor extensions #46943

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

Tensor extensions are implemented in the air subpackage, and Ray Data doesn't handle logs from that package by default

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@@ -25,3 +25,7 @@ loggers:
level: DEBUG
handlers: [file, console]
propagate: False
ray.air.util.tensor_extensions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any downside of including the whole ray.air?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...haven't dug through all of the air code, but would want to avoid writing non-Data logs to ray-data.log (e.g., if there's some Train stuff)

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani enabled auto-merge (squash) August 3, 2024 22:05
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 3, 2024
@bveeramani bveeramani merged commit 7a888e1 into ray-project:master Aug 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants