[ci] pin pip version in min setup #58215
Conversation
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "${python}" -m pip install --upgrade pip | ||
| # 25.3 has breaking change where other Python packages like "click" does not work | ||
| # with it anymore. pip-compile will fail to work with the package's setup code. | ||
| "${python}" -m pip install pip==25.2 |
There was a problem hiding this comment.
Bug: Pip Upgrade Command Missing --upgrade Flag
The pip install pip==25.2 command is missing the --upgrade flag, which prevents older pip versions from being upgraded to 25.2.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request pins the pip version to 25.2 to fix a build failure caused by a breaking change in a newer version. The change is straightforward and should resolve the issue. My review includes a suggestion to improve the comment for better clarity and long-term maintainability by adding a TODO and generalizing the explanation to avoid potential confusion with the unconventional version numbers used.
| # 25.3 has breaking change where other Python packages like "click" does not work | ||
| # with it anymore. pip-compile will fail to work with the package's setup code. | ||
| "${python}" -m pip install pip==25.2 |
There was a problem hiding this comment.
Pinning pip is a good immediate fix for the build issue. For better long-term maintainability and clarity, I have a couple of suggestions.
First, the version numbers 25.3 and 25.2 are unconventional for pip, which usually follows a YY.N format (e.g., 24.1). This can be confusing for future maintainers.
Second, it's a good practice to add a TODO to track temporary fixes like this, making it easier to unpin the version once the upstream issue is resolved.
Here's a suggested change that incorporates these points by making the comment more general and adding a TODO:
| # 25.3 has breaking change where other Python packages like "click" does not work | |
| # with it anymore. pip-compile will fail to work with the package's setup code. | |
| "${python}" -m pip install pip==25.2 | |
| # TODO(ci): Unpin pip once the upstream breaking change is fixed. See [link to issue if available]. | |
| # A recent pip version introduced a breaking change that affects packages like "click" | |
| # and causes pip-compile to fail. Pinning to a known-good version as a workaround. | |
| "${python}" -m pip install pip==25.2 |
lint on code format and cherrypick #58215 --------- Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
fixes min setup build Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
fixes min setup build Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
fixes min setup build