[Data] Increase test_preserve_hash_shuffle_blocks timeout
#59256
Conversation
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request intends to increase the timeout for the flaky test test_preserve_hash_shuffle_blocks by changing its size to 'medium'. However, the code change incorrectly modifies the size of test_download_expression. This appears to be a mistake, as the change does not address the flakiness issue described in the pull request. The size modification should be applied to test_preserve_hash_shuffle_blocks instead.
| py_test( | ||
| name = "test_download_expression", | ||
| size = "small", | ||
| size = "medium", |
There was a problem hiding this comment.
The pull request title and description state the goal is to increase the timeout for test_preserve_hash_shuffle_blocks. However, this change modifies the test_download_expression test instead. This seems to be an error. Please revert this change and apply the size increase to the py_test definition for test_preserve_hash_shuffle_blocks to resolve the flakiness issue.
| size = "medium", | |
| size = "small", |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| py_test( | ||
| name = "test_download_expression", | ||
| size = "small", | ||
| size = "medium", |
There was a problem hiding this comment.
Bug: Wrong test modified - intended test_preserve_hash_shuffle_blocks
The PR intends to increase the timeout for test_preserve_hash_shuffle_blocks which is flaking, but the size change from "small" to "medium" was accidentally applied to test_download_expression instead. The test_preserve_hash_shuffle_blocks test at line 1793-1794 still has size = "small", so the flakiness issue will not be resolved.
## Description `test_preserve_hash_shuffle_blocks` has been flaking consistently. To mitigate the flakiness, this PR bumps the test size from "small" to "medium". This is a follow-up to #59256, which accidentally bumped the wrong test. ``` [2025-12-06T07:06:32Z] //python/ray/data:test_preserve_hash_shuffle_blocks TIMEOUT in 3 out of 3 in 63.4s -- [2025-12-06T07:06:32Z] Stats over 3 runs: max = 63.4s, min = 60.1s, avg = 62.3s, dev = 1.6s [2025-12-06T07:06:32Z] /root/.cache/bazel/_bazel_root/1df605deb6d24fc8068f6e25793ec703/execroot/io_ray/bazel-out/k8-opt/testlogs/python/ray/data/test_preserve_hash_shuffle_blocks/test.log [2025-12-06T07:06:32Z] /root/.cache/bazel/_bazel_root/1df605deb6d24fc8068f6e25793ec703/execroot/io_ray/bazel-out/k8-opt/testlogs/python/ray/data/test_preserve_hash_shuffle_blocks/test_attempts/attempt_1.log [2025-12-06T07:06:32Z] /root/.cache/bazel/_bazel_root/1df605deb6d24fc8068f6e25793ec703/execroot/io_ray/bazel-out/k8-opt/testlogs/python/ray/data/test_preserve_hash_shuffle_blocks/test_attempts/attempt_2.log [2025-12-06T07:06:32Z] ``` See also #58988 Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
…ect#59399) ## Description `test_preserve_hash_shuffle_blocks` has been flaking consistently. To mitigate the flakiness, this PR bumps the test size from "small" to "medium". This is a follow-up to ray-project#59256, which accidentally bumped the wrong test. ``` [2025-12-06T07:06:32Z] //python/ray/data:test_preserve_hash_shuffle_blocks TIMEOUT in 3 out of 3 in 63.4s -- [2025-12-06T07:06:32Z] Stats over 3 runs: max = 63.4s, min = 60.1s, avg = 62.3s, dev = 1.6s [2025-12-06T07:06:32Z] /root/.cache/bazel/_bazel_root/1df605deb6d24fc8068f6e25793ec703/execroot/io_ray/bazel-out/k8-opt/testlogs/python/ray/data/test_preserve_hash_shuffle_blocks/test.log [2025-12-06T07:06:32Z] /root/.cache/bazel/_bazel_root/1df605deb6d24fc8068f6e25793ec703/execroot/io_ray/bazel-out/k8-opt/testlogs/python/ray/data/test_preserve_hash_shuffle_blocks/test_attempts/attempt_1.log [2025-12-06T07:06:32Z] /root/.cache/bazel/_bazel_root/1df605deb6d24fc8068f6e25793ec703/execroot/io_ray/bazel-out/k8-opt/testlogs/python/ray/data/test_preserve_hash_shuffle_blocks/test_attempts/attempt_2.log [2025-12-06T07:06:32Z] ``` See also ray-project#58988 Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Description
test_preserve_hash_shuffle_blockshas been flaking consistently. To mitigate the flakiness, this PR bumps the test size from "small" to "medium".See also #58988