Skip to content

[Data] Increase test_preserve_hash_shuffle_blocks timeout #59256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bveeramani merged 1 commit into from
Dec 8, 2025
Merged

[Data] Increase test_preserve_hash_shuffle_blocks timeout #59256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/ray/data/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1651,7 +1651,7 @@ py_test(

py_test(
name = "test_download_expression",
size = "small",
size = "medium",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The pull request title and description state the goal is to increase the timeout for test_preserve_hash_shuffle_blocks. However, this change modifies the test_download_expression test instead. This seems to be an error. Please revert this change and apply the size increase to the py_test definition for test_preserve_hash_shuffle_blocks to resolve the flakiness issue.

Suggested change
size = "medium",
size = "small",

Copy link

@cursor cursor bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Wrong test modified - intended test_preserve_hash_shuffle_blocks

The PR intends to increase the timeout for test_preserve_hash_shuffle_blocks which is flaking, but the size change from "small" to "medium" was accidentally applied to test_download_expression instead. The test_preserve_hash_shuffle_blocks test at line 1793-1794 still has size = "small", so the flakiness issue will not be resolved.

Fix in Cursor Fix in Web

srcs = ["tests/test_download_expression.py"],
tags = [
"exclusive",
Expand Down