-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update apple-reminders extension #16294
base: main
Are you sure you want to change the base?
Conversation
- lint fix - Merge commit \'627ab1473a43430a5c59346f1a30675af15eb4bc\' - Pull contributions - Merge branch \'contributions/merge-1736598008330\' - Pull contributions - Pull contributions - - Add a new optional view called "Todo", which only shows overdue reminders - Add an option to set the default date of new reminders to today.
Thank you for your contribution! 🎉 🔔 @thomaslombart @tmwrnr @irangarcia @jondelga @phil1995 @michalzuch @ridemountainpig you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. You can expect an initial review within five business days. |
…th groupByDueDates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks weekdays and weekends interval introduced in previous extension updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was sorting removed? It doesn't seem related to the feature you are introducing.
@@ -15,7 +15,13 @@ export function getDateString(date: string) { | |||
export function getTodayInLocalTime() { | |||
return formatISO(new Date(), { representation: "date" }); | |||
} | |||
export function getTimeInLocalTime() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getTodayInLocalTime()
implemented above does the same thing, thing function is obsolete
|
||
export function isPast(date: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isOverdue()
implements the same thing, this function is obsolete
Hey 👋 |
…rvals, and cleaned up some code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🙌
Description
I added two things:
The idea is that I use reminders to manage both work and personal life, and it helps me stay on task if the reminders for stuff I need to do after work don't show up until after work.
And when I default to only show overdue reminders, it's helpful to have newly created reminders default to have a due date, so I don't forget them.
I figured if that works for me, maybe others would like to try that workflow as well. But I made the features optional, since I guess everybody don't work the same way.
I hope you will accept these features, because they are really helpful for me.
And I'm sorry if I made a mess of this pull request. It seems some changes made it in between me forking the extension and publishing it again, and I'm not very well versed in git.
I would also have liked to use
Icon.CheckList
insrc/my-reminders.tsx:48
(as shown in https://developers.raycast.com/api-reference/user-interface/icons-and-images#:~:text=CheckCircle-,CheckList,-CheckRosette), and it worked fine during tests, but the ray-linter told me it wasn't defined and the type definition also seems to be missing. I don't see a way to add the icon to the type definition to satisfy the linter, but if you know how, please feel free to swap outIcon.List
forIcon.CheckList
:-)Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder