-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Apple Reminders] Include optional overdue list view and default due date for new reminders #16294
base: main
Are you sure you want to change the base?
Changes from 2 commits
a905181
f69ab5b
6d4487c
b9c64b5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,13 @@ export function getDateString(date: string) { | |
export function getTodayInLocalTime() { | ||
return formatISO(new Date(), { representation: "date" }); | ||
} | ||
export function getTimeInLocalTime() { | ||
return formatISO(new Date()); | ||
} | ||
|
||
export function isPast(date: string) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
return isBefore(date, isFullDay(date) ? getTimeInLocalTime() : new Date()); | ||
} | ||
export function isOverdue(date: string) { | ||
return isBefore(date, isFullDay(date) ? getTodayInLocalTime() : new Date()); | ||
} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why was sorting removed? It doesn't seem related to the feature you are introducing. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change breaks weekdays and weekends interval introduced in previous extension updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getTodayInLocalTime()
implemented above does the same thing, thing function is obsolete