Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apple-reminders extension #16294

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maxnyby
Copy link
Contributor

@maxnyby maxnyby commented Jan 11, 2025

Description

I added two things:

  • A new optional list view that only shows overdue todos
  • An option to have new reminders default to "today".

The idea is that I use reminders to manage both work and personal life, and it helps me stay on task if the reminders for stuff I need to do after work don't show up until after work.
And when I default to only show overdue reminders, it's helpful to have newly created reminders default to have a due date, so I don't forget them.

I figured if that works for me, maybe others would like to try that workflow as well. But I made the features optional, since I guess everybody don't work the same way.
I hope you will accept these features, because they are really helpful for me.

And I'm sorry if I made a mess of this pull request. It seems some changes made it in between me forking the extension and publishing it again, and I'm not very well versed in git.

I would also have liked to use Icon.CheckList in src/my-reminders.tsx:48 (as shown in https://developers.raycast.com/api-reference/user-interface/icons-and-images#:~:text=CheckCircle-,CheckList,-CheckRosette), and it worked fine during tests, but the ray-linter told me it wasn't defined and the type definition also seems to be missing. I don't see a way to add the icon to the type definition to satisfy the linter, but if you know how, please feel free to swap out Icon.List for Icon.CheckList :-)

Checklist

- lint fix
- Merge commit \'627ab1473a43430a5c59346f1a30675af15eb4bc\'
- Pull contributions
- Merge branch \'contributions/merge-1736598008330\'
- Pull contributions
- Pull contributions
- - Add a new optional view called "Todo", which only shows overdue reminders - Add an option to set the default date of new reminders to today.
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: apple-reminders Issues related to the apple-reminders extension labels Jan 11, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Jan 11, 2025

Thank you for your contribution! 🎉

🔔 @thomaslombart @tmwrnr @irangarcia @jondelga @phil1995 @michalzuch @ridemountainpig you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks weekdays and weekends interval introduced in previous extension updates.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was sorting removed? It doesn't seem related to the feature you are introducing.

@@ -15,7 +15,13 @@ export function getDateString(date: string) {
export function getTodayInLocalTime() {
return formatISO(new Date(), { representation: "date" });
}
export function getTimeInLocalTime() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getTodayInLocalTime() implemented above does the same thing, thing function is obsolete


export function isPast(date: string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isOverdue() implements the same thing, this function is obsolete

@michalzuch
Copy link
Contributor

Hey 👋
Thanks for the PR! Overall, the new changes seem fine to me. However, there are a few things that need to be fixed. Some of them break current functionalities, while others will help maintain cleaner code. I left all the details in the review notes.

Copy link
Contributor

@michalzuch michalzuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: apple-reminders Issues related to the apple-reminders extension extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants