feat(optimus): add GetDeployJobsStatus #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arinda-arif
force-pushed
the
optimus-refresh-async
branch
from
00880bf to
ffb7b51
Compare
| string status = 1; | ||
|
|
||
| repeated DeployJobFailure failures = 2; | ||
| int32 total_succeed = 3; |
There was a problem hiding this comment.
wouldn't it be better to have the failed as well as the total jobs.
There was a problem hiding this comment.
lets have: success_count, failure_count
sravankorumilli
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding GetDeployJobsStatus RPC and modify RefreshJobsResponse as part of this RFC:
https://github.com/odpf/optimus/blob/main/docs/docs/rfcs/20220216_improving_time_and_flow_of_deployment.md
Specifically for this issue: raystack/optimus#181