Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimus): add GetDeployJobsStatus #132

Merged
merged 5 commits into from
Apr 27, 2022
Merged

feat(optimus): add GetDeployJobsStatus #132

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df3d25d
feat(optimus): add GetDeployJobsStatus
arinda-arif Apr 14, 2022
e6ee194
fix(optimus): change success field to status in GetDeployJobsStatusRe…
arinda-arif Apr 18, 2022
ffb7b51
refactor(optimus): remove unused total_failure field from GetDeployJo…
arinda-arif Apr 18, 2022
4e8dd50
fix(optimus): include success_count and failure_count in GetDeployJob…
arinda-arif Apr 20, 2022
4cd6952
fix(optimus): change index of failure_count in GetDeployJobsStatusRes…
arinda-arif Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions odpf/optimus/core/v1beta1/job_spec.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,11 @@ service JobSpecificationService {

// RefreshJobs do redeployment using the current persisted state.
// It will returns a stream of messages which can be used to track the progress.
// Message containing ack are status events other are progress events
rpc RefreshJobs(RefreshJobsRequest) returns (stream RefreshJobsResponse) {}

// GetDeployJobsStatus check status of job deployment.
// It will returns status of the job deployment and the failure details.
rpc GetDeployJobsStatus(GetDeployJobsStatusRequest) returns (GetDeployJobsStatusResponse) {}
}

message DeployJobSpecificationRequest {
Expand Down Expand Up @@ -276,7 +279,23 @@ message RefreshJobsResponse {

// response type differentiate events
string type = 2;
string message = 3;
string value = 3;
sravankorumilli marked this conversation as resolved.
Show resolved Hide resolved

string job_name = 4;
}

message GetDeployJobsStatusRequest {
string deploy_id = 1;
}

message GetDeployJobsStatusResponse {
string status = 1;

repeated DeployJobFailure failures = 2;
int32 total_succeed = 3;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be better to have the failed as well as the total jobs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets have: success_count, failure_count

}

message DeployJobFailure {
string job_name = 1;
string message = 2;
}